Browser storage improvements

SAP / spartacus

Spartacus is a lean, Angular-based JavaScript storefront for SAP Commerce Cloud that communicates exclusively through the Commerce REST API.

Apache License 2.0

740 stars 386 forks source link

Browser storage improvements #10440

Open tobi-or-not-tobi opened 3 years ago

tobi-or-not-tobi commented 3 years ago

Improve the state persistence:

Fix potential errors when session storage is used (to avoid issues with private browsing on safari 13/14).
Start using StatePersistenceService for all browser storage (spartacus-session-data, personalisation-id, ...).
Introduce consent management template validation in the StatePersistenceService for storage.

LTiger14 commented 3 years ago

This issue with Safari described here is fixed in newer versions. Based on caniuse known issues section Safari on desktop and IOS version 10.x does not support setting localStorage and Session storage. For reference current version is 14.

We will still move to the StatePersistenceService since it offers many advantages. We also plan to move the site context to localStorage to be consistent with the rest of the Spartacus persistence.

LTiger14 commented 3 years ago

Updating with some comments from a talk with Tobias:

[ ] Each "state persistence slice" should be able to listen to a different consent
[ ] Some "state persistence slice" should be able to ignore the consents
[ ] Which consent is linked to the part of state should be kept in the associated key
[ ] Persistence should be checked as soon as the app opens
[ ] The persistence handling of consents should be "eagerly" handled
[ ] Services should request a persistence and based on the consents state it should be given
[ ] We should also handle using cookies as persistence tools