Grant_type issue while integrating spartacus with CDC

rmallick26 commented 3 years ago

Describe the bug While integrating CDC with custom spartacus project, we couldn't do login, as the grant_type is hardcoded in cdc-user-authentication-token.service.ts file. Can we integrate the same way how we are fetching client_id & client_secret. As we aren't able to override the service as well and make the changes for the same. Followed all the steps mentioned in https://sap.github.io/spartacus-docs/cdc-integration/#configuring-spartacus-for-sap-customer-data-cloud-integration Even if I remove all the available grant_type from OAuthClientDetails table for the client_id, and keep only custom, it's still throwing the same error.

Tell us the version of Spartacus

Library version: 3.0.0 (latest version)
and for spartacus: 0.300.0

To Reproduce Steps to reproduce the behavior: 1.integrated CDC with spartacus with required APIkey , screenset ID details

try to login
while generating token, it will throw issue as unauthorized grant_type.

Expected behavior The grant_type should be picked based on the authConfig rather than hardcoding the value, similar way how we have implemented client_id and client_secret.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari] - for all browser
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context Add any other context about the problem here.

marlass commented 3 years ago

Worth to do, but it's not super important at the moment.

marlass commented 3 years ago

Idea to implement:

support new property in AuthConfig (only in CDC lib) for the grant_type
use type augmentation https://sap.github.io/spartacus-docs/type-augmentation/#augmenting-modules for AuthConfig, so automcomplete works better
use the value from config with falllback to custom in mentioned service

giancorderoortiz commented 3 years ago

@hackergil fyi

SherwinVarghese commented 1 year ago

Is this still relevant?

SAP / spartacus

Grant_type issue while integrating spartacus with CDC #10775