search

SAP / spartacus

Spartacus is a lean, Angular-based JavaScript storefront for SAP Commerce Cloud that communicates exclusively through the Commerce REST API.
Apache License 2.0
741 stars 388 forks source link

Focus is lost when the quantity is increased / decreased by entering number into the quantity stepper #11556

Open Larisa-Staroverova opened 3 years ago

Uli-Tiger commented 3 years ago

adding focus directive to item-counter does not work. adding focus directive to the the input field inside the item-counter does work. asked in slack channel for advice: https://sap-cx.slack.com/archives/CMBTFUYVA/p1616154609018900

Uli-Tiger commented 3 years ago

we should revisit this after https://github.com/SAP/spartacus/issues/9531 is solved and https://github.com/SAP/spartacus/pull/10507 is merged

Uli-Tiger commented 3 years ago

checked the referenced ticket. I do not see how the refresh focus feature helps us.

Uli-Tiger commented 3 years ago

asked via slack for advice https://sap-cx.slack.com/archives/CMBTFUYVA/p1619186176175800?thread_ts=1616154609.018900&cid=CMBTFUYVA

Uli-Tiger commented 3 years ago

maybe we should just make the necessary changes ourself and create a PR for it also consider DDLB.

giancorderoortiz commented 3 years ago

This is a core Spartacus issue. Please check with @developpeurweb and/or @hackergil. Same situation happens in cart page electronics or b2b.