search

SAP / spartacus

Spartacus is a lean, Angular-based JavaScript storefront for SAP Commerce Cloud that communicates exclusively through the Commerce REST API.
Apache License 2.0
740 stars 384 forks source link

include the semantic route into the scoring of page meta resolvers #12581

Open Platonn opened 3 years ago

Platonn commented 3 years ago

After this lines has been merged https://github.com/SAP/spartacus/pull/12548/files#diff-6b6e4cad16f86e12a80465a80c380dc5ea616f706c52485691491f2ee6c88b91R60-R61, the SavedCartPageMetaResolver handles all my-acocunt pages (having 'AccuntPageTemplate'). But it should handle only saved cart page.

This behavior can be observed only since the saved cart page is first time lazy loaded in the application -> when saved cart page is first time opened.

EDIT: New feature needed: To fix above issue, we should add more specificity to the meta resolver of the saved cart page. We can utilize sematicRoute param for that.

~Should be fixed before 3.4 final.~ We reverted the PR introducing the bug, even before we cut off the 3.4.x release branch. So not super urgent.

Platonn commented 3 years ago

Not an issue in develop, since we did the revert even before cutting off 3.4.x branch : https://github.com/SAP/spartacus/pull/12582. We need to add a funcitonality in the generic page meta resolvers mechanism -> so we can use it to avoid the bug.