search

SAP / spartacus

Spartacus is a lean, Angular-based JavaScript storefront for SAP Commerce Cloud that communicates exclusively through the Commerce REST API.
Apache License 2.0
744 stars 389 forks source link

[WAITING WCMS-M21] merge changes in coreaccelerator for the new cms component types #1426

Closed Xymmer closed 5 years ago

Xymmer commented 5 years ago

Create PR in CMSX and send Bill the JIRA link

WeizhengSap commented 5 years ago

I want to confirm that, we want to move the new types to "cms2" instead of "accleratorcms".

WeizhengSap commented 5 years ago

cms2 PR is here: https://stash.hybris.com/projects/MDM/repos/wcms/pull-requests/947/overview (It was merged!)

spacceleratorsampleaddon PR is here: https://stash.hybris.com/projects/C3PO/repos/spacceleratorsamplesaddon/pull-requests/27/overview

We have to rename the new types of component to follow the name convention in cms2. So, need some changes in SPA. SPA PR is here: https://github.com/SAP/cloud-commerce-spartacus-storefront/pull/1518

This SPA only can be merged when all backend changes merged.

WeizhengSap commented 5 years ago

After cms2 PR merged and released, then spacceleratorsampleaddon PR can be merged.

WeizhengSap commented 5 years ago

To make these 2 components used by other stores, I have to create a PR to acceleratorcms.

PR is here: https://stash.hybris.com/projects/STOREFRONTS/repos/coreaccelerator/pull-requests/567/overview

WeizhengSap commented 5 years ago

We have to create a new PR for cms2: https://stash.hybris.com/projects/MDM/repos/wcms/pull-requests/963/overview. And, we need wait wcms M22, then we can merge the PR in coreaccelerator.