SAP / spartacus

Spartacus is a lean, Angular-based JavaScript storefront for SAP Commerce Cloud that communicates exclusively through the Commerce REST API.
Apache License 2.0
744 stars 389 forks source link

[to test] StoreFinder: Cannot go to a store details page from the result page #1470

Closed KateChuen closed 5 years ago

KateChuen commented 5 years ago

Environment Details

Steps to Reproduce

Observed Results

It shows it on the map, which is good. But there's no way to go to the store details page from there.

storeselected

Expected Results

What if I want to get more details about the store, phone number etc? Should have a way to go to the store details page from there. The only way I found was to go to "All stores" and get it from there, which is a bit more painful for the end-user.

storeselectedallstores
Matejk00 commented 5 years ago

Should be done after #1372

Xymmer commented 5 years ago

1372 is done

Xymmer commented 5 years ago

When clicking a store in the list at left, use the layout seen when you view all stores and click a location. Need to add a back button to go back to the list.

The list area and the location information area should be the same sizes to avoid the map jumping around.

Keep the map same in both views.

Also, from #783 (now closed) - when you click the map marker, the list scrolls up and the screen does too. Instead, when you click map marker, display that store's information (just like if you had clicked the store link at left). And try to avoid the screen jump as described in #783.

kacperknapik commented 5 years ago

I believe this is a lack of feature and not a bug. We should refine this one.

@Matejk00 @Xymmer

Matejk00 commented 5 years ago

Following solution has been implemented: https://github.com/SAP/cloud-commerce-spartacus-storefront/issues/1470#issuecomment-480799066

giancorderoortiz commented 5 years ago

I don't see a fix for this issue yet. Still can't go to store details page.

KateChuen commented 5 years ago

To test later. For now, "Store Finder" is hidden.