Feature: accessibility: close Modals/Popup on ESC key

[devzom]

Is your feature request related to a problem? Please describe. It's not really useful and accessible to need to close modals by mouse click.

Describe the solution you'd like Opened modals should allow to close them on ESC key press.

Describe alternatives you've considered none

Additional context none

[Xymmer]

Hi @devzom, is there a specific modal you are referring to? seems like we do this as standard practice but definitely could have missed some

[devzom]

Hey @Xymmer , sorry for limited information about the issue. I'll explain it now. : ]

That's true that the basic 'Close modal on ESC key' works for the first when user trigger modal open and suddenly use the ESC key

The issue happened in specific situation when user click some action trigger -> modal open -> and then focus the visible modal by mouse click, in this moment it's unavailable to close the modal by ESC key press.

I've tested it on:

• "Add to cart" modal on PDP page. Modal open -> change products Qty -> try to close by ESC key
• "Import Products" on Cart page. -> modal open -> click on content inside modal -> try to close by ESC key

EDIT: 28.02.2022

• also cannot close PDP gallery popup on ESC press

Should I add a video?

best regards, Jacob

[Xymmer]

great! thanks, we'll try to repro and fix

[echianese]

@Xymmer I am working on this issue. Note that I am the assignee. Did you know that?

[Xymmer]

assigning to Dalvir