search

SAP / spartacus

Spartacus is a lean, Angular-based JavaScript storefront for SAP Commerce Cloud that communicates exclusively through the Commerce REST API.
Apache License 2.0
740 stars 386 forks source link

Unmatched selector errors #15363

Open DENCREAT opened 2 years ago

DENCREAT commented 2 years ago

The bug description There are many errors about unmatched selectors regarding SCSS build.

The version of Spartacus

To Reproduce Steps to reproduce the behavior:

  1. Build an app in SSR mode
  2. Open any page
  3. See errors in a node.js console

Expected behavior We shoudn't get any errors regarding SCSS build.

Screenshots image

Additional context I've researched this issue a bit. It seems it's related to Bootstrap 4 and Angular 12 versions. Do you have any plans to upgrade them? Or maybe do you have ideas to fix these errors without upgrading?

p.s. I've also tried to change the .browserslistrc file and played with supported browsers. It didn't has an effect

Xymmer commented 2 years ago

@DENCREAT is anything broken from this problem? we do plan to remove bootstrap eventually and have agnostic style layer but that is for future ... We plan to move to Angular 13 for release 5.0 (and ng14 for 6.0, etc.)... for bootstrap4 upgrade we'll ask about it to our ui dev.

DENCREAT commented 2 years ago

@Xymmer nothing is broken as I see. but we have these errors during the deploy. It pollutes the logs.