SAP / spartacus

Spartacus is a lean, Angular-based JavaScript storefront for SAP Commerce Cloud that communicates exclusively through the Commerce REST API.
Apache License 2.0
740 stars 387 forks source link

[Hold] Screen Reader [NVDA] does not vocalize ng-select selected value #15422

Open FollowTheFlo opened 2 years ago

FollowTheFlo commented 2 years ago

Describe the bug Screen Reader NVDA does not acknowledge value selected with ng-select box. This issue was introduced with #14988 fix. PR #15398

Tell us the version of Spartacus

To Reproduce Steps to reproduce the behavior:

  1. Activate NVDA
  2. Go to Checkout Delivery Address
  3. Click on 'Title' select box, select value 'Mr.'
  4. NVDA does not vocalise the selected value, we get: 'edit has auto complete blank'

Expected behavior NVDA to vocalize the selected value: 'Title Mr. edit has auto complete blank'

Screenshots image expected:

image

video: https://sap-my.sharepoint.com/:v:/p/florent_letendre01/Eexz99OsxUNFqAwGTmdqR5ABVxh1oOvaE70QXM0cbOLb_Q?e=ZMb9hM

Desktop (please complete the following information):

Additional context Replicable with any select box using ng-select By comparing the Accessibility tree, we notice an extra 'generic node' which we believe is causing the issue image

FollowTheFlo commented 2 years ago

I troubleshooted by editing DOM elements: n-select, div(role combox), input. it did not fix the issue.