SAP / spartacus

Spartacus is a lean, Angular-based JavaScript storefront for SAP Commerce Cloud that communicates exclusively through the Commerce REST API.
Apache License 2.0
738 stars 383 forks source link

Implement Add to Home in checkout confirmation page #167

Closed Xymmer closed 5 years ago

Xymmer commented 5 years ago

See #160 for wireframes PWA add to home component implemented already Let's add it to checkout confirmation page

plabadie commented 5 years ago

Hi @marlass, can you please add some smoke test instructions on how to validate the happy path for this feature?

Also, it looks like a mobile platform centric feature. Can I test this on a pc somehow or it's just better to use a mobile device?

Thanks!

marlass commented 5 years ago

About the device

Mobile devices have the best support for add to home screen, however desktop browsers start to catch up. On Windows 10 in Chrome this feature also works. It will move the tab to new window that is styled according to our branding. Additionally, it will be added to start menu and as a icon on desktop. I tested it mostly on this setup and it works 👌

How to test it

Xymmer commented 5 years ago

thanks Marcin! someone from montreal will review, might not necessarily be Patrick.

marlass commented 5 years ago

New PR: https://github.com/SAP/cloud-commerce-spartacus-storefront/pull/346