search

SAP / spartacus

Spartacus is a lean, Angular-based JavaScript storefront for SAP Commerce Cloud that communicates exclusively through the Commerce REST API.
Apache License 2.0
744 stars 389 forks source link

3rd Party libraries cannot be used due to outdated RXJS Version #17857

Closed janwidmer closed 7 months ago

janwidmer commented 1 year ago

Describe the bug For our projects, we use several Angular 3rd party libaries to take in additional functionality. One of the plugins is https://www.npmjs.com/package/ngx-popperjs.

Spartacus 5.x and 6.x have been released with a downgraded RXSJ Version being pinned to RXJS 6.6. In the Angular Ecosystem, Package Major Versions are often compatible with a certain Angular Major Version.

This leads to the following dependency circle problem:

  1. Spartacus 6.x is Compatible with Angular 15
  2. For Angular 15, we need to use the version 15.2.4 of Popper JS
  3. Version 15.x of Popper JS Requires RXJS 7.x as dependancy
  4. Version 7.x is not Compatible with Spartacus

Tell us the version of Spartacus

To Reproduce Steps to reproduce the behavior:

  1. Create a fresh spartacus Project Version 6.4.0
  2. Try to install a library compatible with Angular 15
  3. Notice that you get dependency problems because of mismatching RXJS Versions

Expected behavior The Current Version of Spartacus is compatible with RXJS 7

Desktop (please complete the following information): All Devices

Smartphone (please complete the following information): All Devices

janwidmer commented 7 months ago

Solved with 2211