Stock level status - localization

SAP / spartacus

Spartacus is a lean, Angular-based JavaScript storefront for SAP Commerce Cloud that communicates exclusively through the Commerce REST API.

Apache License 2.0

744 stars 389 forks source link

Stock level status - localization #1826

Closed Platonn closed 5 years ago

Platonn commented 5 years ago

cart-item.component.html in line 107 renders conditionally the stockLevelStatus property only when it has value outOfStock. We should use stockLevelStatus to conditaionally show something, but the message should be different, taken from translations.

Pucek9 commented 5 years ago

Please use convention proposed in #1962

mirkosoft commented 5 years ago

@Platonn here I would also get rid off this method: https://github.com/SAP/cloud-commerce-spartacus-storefront/blob/77c7c65dac0eca5ccb7ae34303f29730df9cc8bf/projects/storefrontlib/src/lib/product/components/product-details/product-summary/product-summary.component.ts#L31

and use cxTranslate in the template.