SAP / spartacus

Spartacus is a lean, Angular-based JavaScript storefront for SAP Commerce Cloud that communicates exclusively through the Commerce REST API.
Apache License 2.0
744 stars 389 forks source link

Simple configurable routes mechanism #184

Closed Platonn closed 5 years ago

Platonn commented 6 years ago

It's subtask of #3

This ticket covers only simple configuration mechanism. The config should be provided statically (without getting routes config via http yet - there is other ticket for that).

Acceptance criteria:

After all many unit/e2e tests should be fixed then, for sure those which:

❓ Maybe it would be good to have another big happy path e2e tests for using translated routes?

Platonn commented 5 years ago

Implementation of simple configurable routes mechanims is already merged into develop for some time.

So I moved out to #564 the acceptance criteria: 'Replace all hardcoded URLs with usages of configurable routes mechanism', which is not merged yet

Platonn commented 5 years ago

Docs https://github.com/SAP/cloud-commerce-spartacus-storefront/blob/develop/projects/core/src/routing/configurable-routes/README.md

Sections:

gladius-mtl commented 5 years ago

Created a follow-up ticket to take care of documentation: GH-742. Moving this ticket now to QA.