SAP / spartacus

Spartacus is a lean, Angular-based JavaScript storefront for SAP Commerce Cloud that communicates exclusively through the Commerce REST API.
Apache License 2.0
726 stars 372 forks source link

chore: update ts-morph lib #18996

Closed kpawelczak closed 7 hours ago

kpawelczak commented 1 week ago

closes: CXSPA-7330

This pull request updates the ts-morph library to version 23.0.0.

  1. Library Update: Updated ts-morph to 23.0.0

  2. Code Adjustments: Modified the readDirSync method in tree-file-system.ts to accommodate the breaking change: The readDirSync method now returns directory entries. https://github.com/dsherret/ts-morph/blob/latest/packages/ts-morph/CHANGELOG.md#breaking-changes-9

github-actions[bot] commented 1 week ago

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`
cypress[bot] commented 4 days ago

3 flaky tests on run #44220 ↗︎

0 119 2 0 Flakiness 3

Details:

Merge ec7c084ffd4d010ecb5af03455b730e9a2804fcd into a518c257e47d7bfce245dbad8b96...
Project: spartacus Commit: a1818c62e1 ℹ️
Status: Passed Duration: 04:22 💡
Started: Jul 5, 2024 12:18 PM Ended: Jul 5, 2024 12:23 PM
Flakiness  cypress/e2e/ssr/pages.core-e2e.cy.ts • 3 flaky tests • SSR View Output Video
Test Artifacts
SSR > should render homepage Test Replay Screenshots Video
SSR > should render PLP Test Replay Screenshots Video
SSR > should render PDP Test Replay Screenshots Video

Review all test suite changes for PR #18996 ↗︎

kimhw0630 commented 1 day ago

Done build test as below Got clean branch npm install npm run build:libs Start Verdaccio ./node_modules/ts-node/dist/bin.js ./tools/schematics/testing.ts

create a new angular app + .npmrc to target verdaccio Install ng add @spartacus/schematics npm start and done smoke test..