SAP / spartacus

Spartacus is a lean, Angular-based JavaScript storefront for SAP Commerce Cloud that communicates exclusively through the Commerce REST API.
Apache License 2.0
739 stars 383 forks source link

fix: Fix sonar issues #19011

Closed rmch91 closed 3 months ago

rmch91 commented 3 months ago

Closes: https://jira.tools.sap/browse/CXSPA-7747

github-actions[bot] commented 3 months ago

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`
github-actions[bot] commented 3 months ago

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`
github-actions[bot] commented 3 months ago

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`
RadhepS commented 3 months ago

Hey I noticed there's an e2e failure, can you verify whether it's related?

github-actions[bot] commented 3 months ago

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`
cypress[bot] commented 3 months ago

3 flaky tests on run #44169 ↗︎

0 119 2 0 Flakiness 3

Details:

Merge 048a441796d3b044b6f6ef7e238ba8ecf75169e9 into e543cfa9b12fe733917055ad4729...
Project: spartacus Commit: e7784b3e86 ℹ️
Status: Passed Duration: 03:55 💡
Started: Jun 27, 2024 9:01 PM Ended: Jun 27, 2024 9:04 PM
Flakiness  cypress/e2e/ssr/pages.core-e2e.cy.ts • 3 flaky tests • SSR View Output Video
Test Artifacts
SSR > should render homepage Test Replay Screenshots Video
SSR > should render PLP Test Replay Screenshots Video
SSR > should render PDP Test Replay Screenshots Video

Review all test suite changes for PR #19011 ↗︎