fix: CXSPA-7665 Remove circular dependency from organization config factories

[pawelfras]

PR contains a fix for an issue spotted by the FSA team, related to circular DI in config factories for organisation components. If a configuration of the Config subclass depends on a feature toggle, we should inject FeatureToggles instead of FeatureConfigService which depends on Config as well. In addition, factory deps have been removed in favour of the inject function to reduce the amount of possible breaking changes in the future.

QA steps:

• build and deploy Spartacus packages locally: npx ts-node ./tools/schematics/testing.ts in the SPA root folder`
• clone https://github.tools.sap/financial-services/financial-services-accelerator-spa and checkout branch compatibilityTesting/CXFSA-2193
• inside FSA projects, change version of all Spartacus packages to 2211.25.0-3
• remove/rename all .npmrc files to ensure that Spartacus is installed from Verdaccio
• run npm i && npm start
• open FSA application in the browser ad verify that the circular DI error is NOT visible in the console:

Note: This change was made around a11yOrganizationLinkableCells toggle (for more, see: CXSPA-1795. To test whether its functionality works:

• go to Spartacus and run npm run start:b2b
• open Spartacus and log in as a user with an admin role (i.e. Linda Wolf)
• go to powertools-spa/en/USD/organization/budgets/Monthly_2_5K_USD
• with toggle a11yOrganizationLinkableCells enabled
• with toggle a11yOrganizationLinkableCells disabled

closes CXSPA-7665

[cypress[bot]]

5 flaky tests on run #44172 ↗︎

0

119

2

0

5

Details:

Merge 3765cc2cba7f47f83b192f6391dfc910f322f610 into 2c46b3769f03a3eb8a1add3efa54...
Project: spartacus	Commit: 3ba8850bad ℹ️
Status: Passed	Duration: 04:13 💡
Started: Jun 28, 2024 1:36 PM	Ended: Jun 28, 2024 1:40 PM

  regression/checkout/checkout-flow.core-e2e.cy.ts • 1 flaky test • B2C

View Output Video

Test		Artifacts
Checkout flow > Mobile > should checkout with a registered user		Test Replay Screenshots Video

  b2b/regression/checkout/b2b-credit-card-checkout-flow.core-e2e.cy.ts • 1 flaky test • B2B

View Output Video

Test		Artifacts
B2B - Credit Card Checkout flow > should checkout using a credit card		Test Replay Screenshots Video

  ssr/pages.core-e2e.cy.ts • 3 flaky tests • SSR

View Output Video

Test		Artifacts
SSR > should render homepage		Test Replay Screenshots Video
SSR > should render PLP		Test Replay Screenshots Video
SSR > should render PDP		Test Replay Screenshots Video

Review all test suite changes for PR #19014 ↗︎