SAP / spartacus

Spartacus is a lean, Angular-based JavaScript storefront for SAP Commerce Cloud that communicates exclusively through the Commerce REST API.
Apache License 2.0
744 stars 389 forks source link

[master] Review public methods in core and make private where required #2140

Closed Xymmer closed 5 years ago

Xymmer commented 5 years ago

As a rule we'd like to expose as many api's as possible. However if we know an api will be refactored, we'd rather not make them public for now. The task here is to review access levels across classes.

Review and make changes based on the following criteria:

List taken from: projects/core/public_api.ts

See tickets: https://github.com/SAP/cloud-commerce-spartacus-storefront/labels/public-api

WeizhengSap commented 5 years ago

We have this ticket https://github.com/SAP/cloud-commerce-spartacus-storefront/issues/2514. So, when you pick up "api review" ticket, you can leave out occ for now.