Close button on selected facets with long text is not vertical centered

SAP / spartacus

Spartacus is a lean, Angular-based JavaScript storefront for SAP Commerce Cloud that communicates exclusively through the Commerce REST API.

Apache License 2.0

744 stars 389 forks source link

Closed Matejk00 closed 5 years ago

Matejk00 commented 6 years ago

Close button on selected facets with long text is not vertical centered.

Steps to reproduce:

facet_close_alignment

Matejk00 commented 6 years ago

As i see issue was already reviewed.

Based on PR comments i suppose to move it back into Todo and assign @RomeroDiver

Matejk00 commented 5 years ago

Now selected facets are well aligned. Regarding to this comment https://github.com/SAP/cloud-commerce-spartacus-storefront/pull/264#issuecomment-438267169 we decided to move close buttons into top right corner which is more intuitive solution for closing items.