Use WinRef in YotpoService to avoid breaking ssr

SAP / spartacus

Spartacus is a lean, Angular-based JavaScript storefront for SAP Commerce Cloud that communicates exclusively through the Commerce REST API.

Apache License 2.0

744 stars 389 forks source link

Use WinRef in YotpoService to avoid breaking ssr #2991

Closed Platonn closed 5 years ago

Platonn commented 5 years ago

In YotpoService we use the implicit global document which may break SSR. Instead, we should use the WindowRef wrapper object and it's document property.

qjimmy commented 5 years ago

Muhammad: Fix ready. Waiting for access to generate PR.

mazamcodes commented 5 years ago

PR https://github.com/SAP/cloud-commerce-spartacus-storefront/pull/4753

KateChuen commented 5 years ago

QA Steps required please.