search

SAP / spartacus

Spartacus is a lean, Angular-based JavaScript storefront for SAP Commerce Cloud that communicates exclusively through the Commerce REST API.
Apache License 2.0
744 stars 389 forks source link

Fix sonar accessibility warning by adding alt attribute #3203

Closed RadhepS closed 5 years ago

RadhepS commented 5 years ago

Screen Shot 2019-06-14 at 2 40 51 PM

Add alt attribute

RadhepS commented 5 years ago

PR: https://github.com/SAP/cloud-commerce-spartacus-storefront/pull/3205

Unsure we should do this because an alt attribute for an image should be descriptive but ours can't because the images used will be dynamic.

RadhepS commented 5 years ago

Not valid fix since images are dynamic - Spoke with GIl and we'll be ignoring this since its minor