search

SAP / spartacus

Spartacus is a lean, Angular-based JavaScript storefront for SAP Commerce Cloud that communicates exclusively through the Commerce REST API.
Apache License 2.0
744 stars 389 forks source link

Graceful failure for cart calls #4043

Closed LTiger14 closed 5 years ago

LTiger14 commented 5 years ago

See comment: https://github.com/SAP/cloud-commerce-spartacus-storefront/issues/1792#issuecomment-519247141

As mentioned in the comment above when certain calls to the cart fail, the site can enter an infinite loop. This is not a configurable endpoints issue but it can be reproduced using the feature as described in the comment above.

The storefront should fail gracefully if the calls return errors.

LTiger14 commented 5 years ago

For review/QA:

Execute steps from https://github.com/SAP/cloud-commerce-spartacus-storefront/issues/1792#issuecomment-519247141

LTiger14 commented 5 years ago

For QA:

1.Before starting, add the feature flag in app.module.ts as follows

features: {
 configurableOccEndpoints: true
}
  1. Modify the endpoints and restart server
giancorderoortiz commented 5 years ago

Test successful. Infinite loop not seen. 🆗 Cart fails within reason throughout. 🆗 Test done on dev-19