search

SAP / spartacus

Spartacus is a lean, Angular-based JavaScript storefront for SAP Commerce Cloud that communicates exclusively through the Commerce REST API.
Apache License 2.0
738 stars 383 forks source link

Fix a test from address-form.component.spec.ts #418

Closed znikola closed 5 years ago

znikola commented 5 years ago

There's a failing test in address-form.component.spec.ts that's being skipped withxit: should call "verifyAddress" function when being clicked and when form is valid.

It's silently failing sometimes, and sometimes it's reported as a failed test.

Of the test is green, check the browser's console output, you should see something like:

Uncaught TypeError: Cannot convert undefined or null to object
    at Function.keys (<anonymous>)
    at TapSubscriber.keys [as _tapNext] (address-form.component.ts:58)
    at TapSubscriber.push.../../node_modules/rxjs/_esm5/internal/operators/tap.js.TapSubscriber._next (:9877/Users/i864078/workspaces/spa-gh/node_modules/rxjs/_esm5/internal/operators/tap.js?:45)
    at TapSubscriber.push.../../node_modules/rxjs/_esm5/internal/Subscriber.js.Subscriber.next (:9877/Users/i864078/workspaces/spa-gh/node_modules/rxjs/_esm5/internal/Subscriber.js?:54)
    at BehaviorSubject.push.../../node_modules/rxjs/_esm5/internal/BehaviorSubject.js.BehaviorSubject._subscribe (:9877/Users/i864078/workspaces/spa-gh/node_modules/rxjs/_esm5/internal/BehaviorSubject.js?:22)
    at BehaviorSubject.push.../../node_modules/rxjs/_esm5/internal/Observable.js.Observable._trySubscribe (:9877/Users/i864078/workspaces/spa-gh/node_modules/rxjs/_esm5/internal/Observable.js?:43)
    at BehaviorSubject.push.../../node_modules/rxjs/_esm5/internal/Subject.js.Subject._trySubscribe (:9877/Users/i864078/workspaces/spa-gh/node_modules/rxjs/_esm5/internal/Subject.js?:89)
    at BehaviorSubject.push.../../node_modules/rxjs/_esm5/internal/Observable.js.Observable.subscribe (:9877/Users/i864078/workspaces/spa-gh/node_modules/rxjs/_esm5/internal/Observable.js?:29)
    at DoOperator.push.../../node_modules/rxjs/_esm5/internal/operators/tap.js.DoOperator.call (:9877/Users/i864078/workspaces/spa-gh/node_modules/rxjs/_esm5/internal/operators/tap.js?:18)
    at AnonymousSubject.push.../../node_modules/rxjs/_esm5/internal/Observable.js.Observable.subscribe (:9877/Users/i864078/workspaces/spa-gh/node_modules/rxjs/_esm5/internal/Observable.js?:24)
    at ____________________Elapsed_17_ms__At__Mon_Nov_26_2018_12_26_36_GMT_0500__GMT_05_00_ ()
    at Object.onScheduleTask (:9877/Users/i864078/workspaces/spa-gh/node_modules/zone.js/dist/zone-testing.js?:108)
    at ZoneDelegate.push.../../node_modules/zone.js/dist/zone.js.ZoneDelegate.scheduleTask (:9877/Users/i864078/workspaces/spa-gh/node_modules/zone.js/dist/zone.js?:401)
    at Object.onScheduleTask (:9877/Users/i864078/workspaces/spa-gh/node_modules/zone.js/dist/zone.js?:297)
    at ZoneDelegate.push.../../node_modules/zone.js/dist/zone.js.ZoneDelegate.scheduleTask (:9877/Users/i864078/workspaces/spa-gh/node_modules/zone.js/dist/zone.js?:401)
    at Zone.push.../../node_modules/zone.js/dist/zone.js.Zone.scheduleTask (:9877/Users/i864078/workspaces/spa-gh/node_modules/zone.js/dist/zone.js?:232)
    at Zone.push.../../node_modules/zone.js/dist/zone.js.Zone.scheduleMacroTask (:9877/Users/i864078/workspaces/spa-gh/node_modules/zone.js/dist/zone.js?:255)
    at scheduleMacroTaskWithCurrentZone (:9877/Users/i864078/workspaces/spa-gh/node_modules/zone.js/dist/zone.js?:1114)
    at :9877/Users/i864078/workspaces/spa-gh/node_modules/zone.js/dist/zone.js?:2090
WeizhengSap commented 5 years ago

PR: https://github.com/SAP/cloud-commerce-spartacus-storefront/pull/421