search

SAP / spartacus

Spartacus is a lean, Angular-based JavaScript storefront for SAP Commerce Cloud that communicates exclusively through the Commerce REST API.
Apache License 2.0
744 stars 389 forks source link

Use feature toggle for enabling Kyma #4481

Closed josecervera closed 4 years ago

josecervera commented 5 years ago

Reading the docs, I see Kyma integration is enabled by changing a property in the authentication configuration: https://sap.github.io/cloud-commerce-spartacus-storefront-docs/kyma-integration/

For coherence, I think this should probably be a feature flag toggle which -I believe- were introduced later in the code:

https://sap.github.io/cloud-commerce-spartacus-storefront-docs/feature-flags-and-code-deprecation/

znikola commented 4 years ago

Hi @josecervera, Thanks for pointing this out. You are right, we could use a feature toggle instead of the enable property in the config. Another option that we will consider is to remove the flag all together, because importing the KymaModule should be enough to enable kyma integration.

znikola commented 4 years ago

Docs PR: https://github.com/SAP/spartacus-docs/pull/560 PR: https://github.com/SAP/spartacus/pull/7302