tobi-or-not-tobi commented 5 years ago

The product and category page routes do have the ability to match the /p or /c prefix, with any additional prefixes. The route is taken into account, however, the final URL isn't updated in case of misuse.

There are different use cases where we should come up with a solution:

In case someone would post a link to /crazy/company/p/1234, the product detail page would still fetch the product data and nothing would change.
The product name of the route is not validated against the actual title. If a link to /p/1234/shitty-product would be working fine.
The same is true for any of the ContentPages fetched by the CMS backend. One could post a link on twitter to /corporate/shitty-company, and the CMS will render the page for /company.

We should come up with a solution for these use-cases. There's likely an alternative approach for product or content pages.

Platonn commented 4 years ago

Related to #5863 (Redirects in SSR to canonical url)

Xymmer commented 4 years ago

5863 is done, what's next?

guiliguili commented 3 years ago

Hi, Any news on this issue ?

This seems quite critical as it can be interpreted as duplicate content by search engine which is not good in terms of SEO. Please also notice that this also affects Category Page.

neilhubertprice commented 3 years ago

@Xymmer When you say "#5863 is done" .. not really, it got closed as a duplicate of this ticket

Platonn commented 2 years ago

neilhubertprice commented 2 years ago

@Platonn I would say it is only loosely related to #9681 - that is about URLs that fall through to the catch-all and should generate 404s, whereas this about redirect to canonical URLs where URLs have a correct/valid pattern but some parts of the URL are not current.

https://github.com/SAP/spartacus/issues/5863 which got closed as a duplicate of this talks more specifically about PDP/PLP pages

SAP / spartacus

Redirect suffix routes to best path match (introduce canonical PDP URL) #5023

5863 is done, what's next?