Closed Xymmer closed 5 years ago
@Xymmer "standard checkboxes on left side" implies removing the accordions, can you please confirm this is what you want. Manu, can you please sync-up with Bill to retrofit these mockups so they become official guidelines and post them in this ticket for the record.
@Xymmer I'm just realizing, if you choose to remove the accordions, you don't my intervention, maybe just for code reviewing, but most of the refactoring can be done by a developer directly in the html by removing the accordions code, simplifying the checkboxes and unplug the styles... since checkboxes are already pre-styled as global form elements.
sounds good! thanks
Points from above:
The description (the text underneath the 'name') should be a few points smaller : This is a breaking change
I'd expect that I can click the checkbox or any part of the name, but not necessarily the description, to select the check box: Done
The Reject/Accept text is changed to Select all and Clear all and no need for a vertical | bar: Done
Careful of what happens in mobile: It looks great
If the anon consent modal has too many consents, will it scroll?: Yes
Tested on dev17.
[x] Now checkboxes are used.
[ ] The description (the text underneath the 'name') should be a few points smaller I'd expect that I can click the checkbox or any part of the name, but not necessarily the description, to select the check box -> I don't see the name being displayed anymore. I see the description only.
[x] The Reject/Accept text is changed to Select all and Clear all and no need for a vertical | bar
[ ] Careful of what happens in mobile -> I think it's missing some padding on both sides for the consents
[x] If the anon consent modal has too many consents, will it scroll?
[x] The description (the text underneath the 'name') should be a few points smaller
[ ] I'd expect that I can click the checkbox or any part of the name, but not necessarily the description, to select the check box -> Clicking the description also selects and unselects the checkbox. This is because they are the same 'component' i think. Because if the description is short, you'll see that it's displayed on the same line as the title. @Xymmer Your call! Opened ticket https://github.com/SAP/cloud-commerce-spartacus-storefront/issues/5229 to address this issue.
[x] Careful of what happens in mobile
In both anonymous and logged-in-user consents, switches to the right were used. We should have stayed with standard checkboxes on left side. Sorry to ask but let's switch it back :) The old code is still there because Nik added feature flags.
Example mockup:
Notes about this: