SAP / spartacus

Spartacus is a lean, Angular-based JavaScript storefront for SAP Commerce Cloud that communicates exclusively through the Commerce REST API.
Apache License 2.0
744 stars 389 forks source link

Revert to checkboxes + 'x all' fix links #5104

Closed Xymmer closed 5 years ago

Xymmer commented 5 years ago

In both anonymous and logged-in-user consents, switches to the right were used. We should have stayed with standard checkboxes on left side. Sorry to ask but let's switch it back :) The old code is still there because Nik added feature flags.

Example mockup: image

Notes about this:

developpeurweb commented 5 years ago

@Xymmer "standard checkboxes on left side" implies removing the accordions, can you please confirm this is what you want. Manu, can you please sync-up with Bill to retrofit these mockups so they become official guidelines and post them in this ticket for the record.

developpeurweb commented 5 years ago

@Xymmer I'm just realizing, if you choose to remove the accordions, you don't my intervention, maybe just for code reviewing, but most of the refactoring can be done by a developer directly in the html by removing the accordions code, simplifying the checkboxes and unplug the styles... since checkboxes are already pre-styled as global form elements.

Xymmer commented 5 years ago

sounds good! thanks

LTiger14 commented 5 years ago

Points from above:

The description (the text underneath the 'name') should be a few points smaller : This is a breaking change

I'd expect that I can click the checkbox or any part of the name, but not necessarily the description, to select the check box: Done

The Reject/Accept text is changed to Select all and Clear all and no need for a vertical | bar: Done

Careful of what happens in mobile: It looks great

If the anon consent modal has too many consents, will it scroll?: Yes

KateChuen commented 5 years ago

Tested on dev17.

Screen Shot 2019-10-29 at 9 13 45 AM

KateChuen commented 5 years ago