search

SAP / spartacus

Spartacus is a lean, Angular-based JavaScript storefront for SAP Commerce Cloud that communicates exclusively through the Commerce REST API.
Apache License 2.0
729 stars 375 forks source link

Drop default config for 'context' including languages and currencies #5241

Open Platonn opened 4 years ago

Platonn commented 4 years ago

As soon as we have self site-recognition (mutlisite) in place (https://github.com/SAP/cloud-commerce-spartacus-storefront/issues/1810), we don't need to provide multiple languages and currencies in our default config.

It's a breaking change, becuase some customers could rely on our default config with languages and currencies, so it's a thing for 2.0 .

Platonn commented 4 years ago

Let's put it on hold since it's not highest priority for 2.0 and it requires additional work regarding the deployment process and installation schematics (requires adding new schematics installation options: 'langauge' and 'currency' - of custom array comma-delimited format - see https://stackoverflow.com/questions/54410585/pass-collection-into-custom-angular-schematic).

Platonn commented 4 years ago

As an alternative to providing language & currency config explicitly in all places (schematics, installation scripts and in stackblitz examples), we could investigate making Spartacus able to work without any preconfigured currency or language on the frontend side and rely only on the default lang & curr configured on the backend side.