SAP / spartacus

Spartacus is a lean, Angular-based JavaScript storefront for SAP Commerce Cloud that communicates exclusively through the Commerce REST API.
Apache License 2.0
744 stars 389 forks source link

Coupons/Promotions Not Merged Properly #5253

Open giancorderoortiz opened 5 years ago

giancorderoortiz commented 5 years ago

(Assumes out of the box sample data)

Steps to Reproduce:

  1. Navigate to Spartacus storefront.
  2. Sign in as registered user.
  3. Add any product to cart, so that cart total is greater than $10
  4. Apply coupon "CouponForCart"
  5. Sign out.
  6. Reload home page.
  7. Navigate to "camera lenses" subcategory and add any camera lense.
  8. Navigate to cart page (here, as anonymous user).
  9. Apply coupon "CouponForProduct"
  10. Click in Sign / In Register.
  11. Navigate to cart page.

Expected Results:

  1. Merge cart with coupons "CouponForCart" and "CouponForProduct" successfully applied.

Actual Results:

  1. Merged cart as far as skus. However, only registered user coupon was applied. 11.a. "CouponForProduct" not applied.

Anonymous Cart: Screen Shot 2019-11-01 at 10 33 30 AM

Merged Cart: Screen Shot 2019-11-01 at 10 35 47 AM

giancorderoortiz commented 5 years ago

Related: https://github.com/SAP/cloud-commerce-spartacus-storefront/issues/5189

giancorderoortiz commented 5 years ago

I don't see cart merge with old accelerator, therefore, below images show basically anonymous cart overriding user's cart after sign-in.

Old Accelerator:

Cart page before sign-in: Screen Shot 2019-11-01 at 10 13 48 AM

Cart page after sign-in:

Screen Shot 2019-11-01 at 10 14 29 AM

LTiger14 commented 5 years ago

Back end issue see RAY-472

Xymmer commented 4 years ago

Now fixed in https://jira.hybris.com/browse/C3PO-1949

giancorderoortiz commented 3 years ago

@LTiger14 can this be fixed now?

giancorderoortiz commented 3 years ago

This continues to be an issue with Spartacus 3.4. Is it related to cart merge strategy previously discussed?