[Blocked by 5562] SSR in spartacus installation not working from schematics

SAP / spartacus

Spartacus is a lean, Angular-based JavaScript storefront for SAP Commerce Cloud that communicates exclusively through the Commerce REST API.

Apache License 2.0

744 stars 388 forks source link

[Blocked by 5562] SSR in spartacus installation not working from schematics #5370

Closed hackergil closed 3 years ago

hackergil commented 5 years ago

Our spartacus installation script is not installing spartacus with SSR correctly

The manual steps are outdated
The schematics fail with the following:

Installing packages... ✅️ Added '@angular/platform-server' into dependencies ✅️ Added '@nguniversal/express-engine' into dependencies ✅️ Added 'ts-loader' into devDependencies ✅️ Added 'webpack-cli' into devDependencies Cannot read property 'kind' of undefined

I believe this is also a problem with the schematics overall installing the latest beta in a shell app in SSR mode

psmul commented 5 years ago

Could not reproduce the problem. Tried both ways: building locally schematics lib and using our @spartacus/schematics approach. Can you provide more details? Environment, script used, params or branch? @hackergil

hackergil commented 5 years ago

I tried using the spartacus installation script with importing libraries from npm in a new shell app.

psmul commented 5 years ago

https://github.com/SAP/cloud-commerce-spartacus-storefront-docs/issues/413

hackergil commented 5 years ago

@psmul Sorry, I just tested the schematics in a new shell app and it's still failing. I guess I didn't get what the fix for this ticket was. Can you clarify?

psmul commented 5 years ago

@hackergil Mostly just adjusting documentation. Maybe I was too hurry with closing it with mistakenly thinking it's working as I wasn't able to reproduce a problem.

psmul commented 5 years ago

After some investigation, we've find out that the problem is in angular-cli version. For this repo: https://github.tools.sap/cx-commerce/spartacus-installation And file: spartacus.sh Please update Angular-CLI version from '~8.0.0' to '~8.2.0'. After that, it all should work fine. Tested locally with different angular-cli versions higher than 8.0.0.

hackergil commented 5 years ago

After following the above, the script is now failing on the PWA step, as described in #5562. We depend on these changes to fix this.

plabadie commented 3 years ago

Closing, can't repro. Moreover, the script was updated a lot since 2019 and is not known to fail recently.