search

SAP / spartacus

Spartacus is a lean, Angular-based JavaScript storefront for SAP Commerce Cloud that communicates exclusively through the Commerce REST API.
Apache License 2.0
740 stars 384 forks source link

cx-merchandising-carousel styling not available in 1.4 #6336

Closed matt-williams8 closed 4 years ago

matt-williams8 commented 4 years ago

Environment Details

Steps to Reproduce

  1. Run spartacus with CDS enabled.
  2. Navigate to a page with a merchandising carousel configured

Observed Results

The style of the cx-merchandising-carousel does not match the styling of standard product carousels. E.g. the product name and price in a are not formatted the same as in a standard carousel.

Expected Results

cx-merchandising-caorusels should be styled in the same way as a standard product carousel

Additional Information

As part of the cds-integration the cx-merchandising-carousel scss file was added to storefront styles. As cds was added to spartacus from 1.5 onwards, this styling is not yet available in storefront styles. Is there anyway to instead move the styling into the cds module so that it is always available?

bgambocjaviniar commented 4 years ago

not a problem since cds work is 1.5 and above