search

SAP / spartacus

Spartacus is a lean, Angular-based JavaScript storefront for SAP Commerce Cloud that communicates exclusively through the Commerce REST API.
Apache License 2.0
744 stars 389 forks source link

Aria-labels translation #6492

Closed CarlEricLavoie closed 3 years ago

CarlEricLavoie commented 4 years ago

Aria-labels and other hidden attributes should be translated. As of now those attributes are hardcoded in the HTM.

see : https://github.com/SAP/cloud-commerce-spartacus-storefront/blob/develop/projects/storefrontlib/src/cms-components/product/product-list/container/product-list.component.html

as an example.

Environment Details

Expected Results

Aria-labels should be translated using the i18n mechanism.

kacperknapik commented 4 years ago

We plan to handle ARIA-labels/attributes in the future, when we implement more accessibility features. Currently we don't handle them at all.