search

SAP / spartacus

Spartacus is a lean, Angular-based JavaScript storefront for SAP Commerce Cloud that communicates exclusively through the Commerce REST API.
Apache License 2.0
740 stars 385 forks source link

Mobile: navigating through pages using the navbar (hamburger) #7727

Open bgambocjaviniar opened 4 years ago

bgambocjaviniar commented 4 years ago

Describe the bug When in mobile view, and navigating through the navbar (the hamburger), we can not get out of it when we click a category that we are already on.

To Reproduce Steps to reproduce the behavior:

  1. make sure you're in mobile view
  2. Navigate to a category, for example, Brands/all/c/brands using the url or through the navbar under the dropdown brands -> shop all brands
  3. repeat step 2 only by clicking the category through the navbar
  4. bug (it does not close the navbar, such as when we navigate to a different category page)

Expected behavior The navbar should close when clicking on the same category that will send you to the same page

giancorderoortiz commented 3 years ago

Please fix conflicts in pr(if any), and approve/reject. Would like to test this fix soon.

giancorderoortiz commented 3 years ago

Please add screenshots of issue you're describing