search

SAP / spartacus

Spartacus is a lean, Angular-based JavaScript storefront for SAP Commerce Cloud that communicates exclusively through the Commerce REST API.
Apache License 2.0
744 stars 388 forks source link

AddToHomeScreenService can't be imported from the @spartacus/storefront #8170

Closed blaiseup closed 4 years ago

blaiseup commented 4 years ago

Describe the bug The AddToHomeScreenService, used in the pwa module, is not exported in the index.ts file, so it can not be imported from the @spartacus/storefront.

To Reproduce Steps to reproduce the behavior:

  1. Import service in any component

Expected behavior The service should be injected without errors

Xymmer commented 4 years ago

Fix version is set to 2.1 but make sure to add fix to 2.0.x maintenance

janrode commented 4 years ago

~Duplicate of #8079~ This ticket has more detailed info about the problem

giancorderoortiz commented 4 years ago

how to qa?

mszczepaniak commented 4 years ago

~As far as I see it's only merged to develop, need to be merged also to 2.0.x .~ done

kacperknapik commented 4 years ago

how to qa?

~QA steps: import and use AddToHomeScreenService from @spartacus/storefront, try to build the app and check if the error still appears~ After some thinking, this ticket doesn't need QA - it's just an import