Changes to forms now that title code no longer mandatory

[Xymmer]

Title code no longer required (dependency on RAY-74), we'll remove it on some pages and make sure it is optional for others

Remove from:

• Registration page
• Shipping and billing address pages during checkout

Display but make sure it is optional from:

• Address management edit/add (add "None" option but send blank to backend; make "None" the default in grey instead of "Select title")

Check if elsewhere.

Check related tickets #440 and #287 and see if they are fixed or we can close them. If not, pull them into the sprint and fix them.

[Xymmer]

update: RAY-74 was put on hold while waiting for a milestone, i've asked for it to get back on track

[Xymmer]

update: RAY-74 now merged and integrated with M3 check with gil to ensure the server your using has it or else it will fail still if trying to submit an address without it.

[Pucek9]

Backend doesn't allow for register user without titleCode ('' or null):

message: "This field is required."
reason: "missing"
subject: "titleCode"
subjectType: "parameter"
type: "ValidationError"

Similarly in adding address / shipping address:

message: "This field is required and must to be between 1 and 255 characters long."
reason: "invalid"
subject: "titleCode"
subjectType: "parameter"
type: "ValidationError"

[Xymmer]

check with gil if we have latest milestones / cs's from them

[Xymmer]

also, i realized we'll be causing a problem with this change for people who don't have 1905. is there a way to test if this field is mandatory, and hide it or set it to 'none' (and we'd have to add 'none' to the backend)? the way people test for features in JS so that people using 1811 or 1808 aren't prevented from registering a user.

[Pucek9]

also, i realized we'll be causing a problem with this change for people who don't have 1905. is there a way to test if this field is mandatory, and hide it or set it to 'none' (and we'd have to add 'none' to the backend)? the way people test for features in JS so that people using 1811 or 1808 aren't prevented from registering a user.

I have tried use 'none' as value. Validation is more complex. Registration:

      "message" : "TitleModel with code 'none' not found!",
      "type" : "UnknownIdentifierError"

Adding address:

      "message" : "No result for the given example [TitleModel (<unsaved>)] was found. Searched with these attributes: {code=none}",
      "type" : "UnknownIdentifierError"

[Pucek9]

Branch with changes is already done, but need wait for testing possibility https://github.com/SAP/cloud-commerce-spartacus-storefront/tree/feature/GH-872

[Xymmer]

we'd have to add 'none' as a valid title value in the backend

[Xymmer]

Hey all, after talking with Patrick I realized that my request and the solution i proposed would result in emails being sent in the form of "None Bill Marcotte".

At the same time we need to be backwards compatible with 1811 because otherwise people won't be able to register.

If you submit an OCC request without title code, this is returned in the body:

       {
            "message": "This field is required.",
            "reason": "missing",
            "subject": "titleCode",
            "subjectType": "parameter",
            "type": "ValidationError"
        },

So:

• Keep "salutation" field in registration and shipping address pages
• Change the "Select title" grayed out option to a selectable option titled "No title" (which submits empty string to backend) - this doesn't come from backend, it's in Spartacus.
• Action button activates even if "Title" is set to "No title" (Action button in registration is "Register", in shipping address it's "Continue") It's not visible in Billing Address (I guess it's not needed there? we're so inconsistent :) )
• If you submit and the backend is 1811 or earlier, an error message is returned. If titleCode is the error, display note underneath the title form. Display "Please correct the errors below" in the top red global notification bar. If you submit with 1905, you won't get an error.

Let me know if this makes sense!

Also make sure Matt knows about the spartacus vs backend version issue for documentation.

[Xymmer]

to add to this, i've asked tobias what he thinks of just adding a configuration titlecodemandatory=false and then we behave based on that. so we don't have to add too much logic to spartacus.

[Xymmer]

so still blocked :)

[Pucek9]

Waiting for VPN credentials

[Xymmer]

if Mr. Pucek9 doesn't get vpn access soon, let's assign to someone else.

[Pucek9]

Tested manually on: https://dev-com-17.accdemo.b2c.ydev.hybris.com:9002 - looks good

I've added workaround to convert empty string to null and vice versa in sending/fetching data in address book form. Please tell me what do you think about this change, maybe let decide to update backend?

[Pucek9]

17: allow register and add address without selecting title (workaround converts empty string to null and null to empty string) 20: not allow for register without title (workaround changes server's global message from "'This field is required.'" to "Title is required" ). Not allow to add/update address without title, replaced message: "Invalid Address" / "Title is required"