Open giancorderoortiz opened 4 years ago
False positive, as <i>
tag here means icon, not emphasized text. Using em
instead would be semathically wrong here.
False positive, we use -bracket-i-bracket- on purpose for icons. Can we disable this rule?
After some checks, only user with admin role can provide any changes. After talking with @marlass we would like to disable this single occurrence for now, as rule still might come useful. Assigning @hackergil
@hackergil who can help us disable this rule in SonarC?
This issue affects our overall Reliability Rating in Sonar Cloud. Visible to CX.
Reliability Rating: B
Link https://sonarcloud.io/component_measures?id=sap_cloud-commerce-spartacus-storefront&metric=reliability_rating&view=list
Files: projects/storefrontlib/src/cms-components/misc/icon/icon.component.html
Issue: Replace this tag by
<i [outerHTML]="icon"></i><ng-content></ng-content>