SAP / spartacus

Spartacus is a lean, Angular-based JavaScript storefront for SAP Commerce Cloud that communicates exclusively through the Commerce REST API.
Apache License 2.0
738 stars 383 forks source link

[Disable rule] SonarC. Reliability Rating. Use <em> instead of <i> #8827

Open giancorderoortiz opened 4 years ago

giancorderoortiz commented 4 years ago

This issue affects our overall Reliability Rating in Sonar Cloud. Visible to CX.

Reliability Rating: B

Link https://sonarcloud.io/component_measures?id=sap_cloud-commerce-spartacus-storefront&metric=reliability_rating&view=list

Files: projects/storefrontlib/src/cms-components/misc/icon/icon.component.html

Issue: Replace this tag by <i [outerHTML]="icon"></i><ng-content></ng-content>

giancorderoortiz commented 4 years ago

Screen Shot 2020-09-07 at 6 50 23 AM

dunqan commented 4 years ago

False positive, as <i> tag here means icon, not emphasized text. Using em instead would be semathically wrong here.

Xymmer commented 4 years ago

False positive, we use -bracket-i-bracket- on purpose for icons. Can we disable this rule?

psmul commented 3 years ago

After some checks, only user with admin role can provide any changes. After talking with @marlass we would like to disable this single occurrence for now, as rule still might come useful. Assigning @hackergil

giancorderoortiz commented 3 years ago

@hackergil who can help us disable this rule in SonarC?