SAP / spartacus

Spartacus is a lean, Angular-based JavaScript storefront for SAP Commerce Cloud that communicates exclusively through the Commerce REST API.
Apache License 2.0
744 stars 389 forks source link

missing hamburger dependency #904

Closed tobi-or-not-tobi closed 5 years ago

tobi-or-not-tobi commented 5 years ago

With the change of #679 the style lib generates the hamburger menu on the fly. This requires an external dependency to be installed. This is not added to the docs.

We could do different things here:

We should add a note temporarily to the installation guide, so that hamburger is added as a dependency in any case.

marlass commented 5 years ago

Yesterday after information about the issue I added hamburger as dependency to @spartacus/styles. Release still needs to be merged to master and develop: https://github.com/SAP/cloud-commerce-spartacus-storefront/pull/874

Xymmer commented 5 years ago

closing as fixed in another pr