search

SAP / spartacus

Spartacus is a lean, Angular-based JavaScript storefront for SAP Commerce Cloud that communicates exclusively through the Commerce REST API.
Apache License 2.0
744 stars 389 forks source link

First button in checkout address-form is not correct #919

Closed WeizhengSap closed 5 years ago

WeizhengSap commented 5 years ago

If user does not have any addresses, then in the address-form, the first button should be "Back To Cart" (clicking it should go to cart page). If the user has addresses and want to add another address, in the form the first button is "Change Address"

screen shot 2019-01-17 at 3 11 10 pm

Xymmer commented 5 years ago

also check payment method page, if you have no addresses yet, you shouldn't see it (also 'change address' is misleading, should be choose?)

mirkosoft commented 5 years ago

I have added a fix for this: https://github.com/SAP/cloud-commerce-spartacus-storefront/commit/8c52d80d3b9d663f30d45b97d472f2ead23aa9db

However, @Xymmer shouldn't be better to name this button to "Back to Shipping Address" or "Choose from existing addresses" or just "Back"? Currently I have changed it to "Choose address" as you proposed.

For the payment page I wasn't able to reach it without address choose/provide.

kacperknapik commented 5 years ago

@mirkosoft I would suggest to create e2e test for those cases (button text with or without existing addresses)

mirkosoft commented 5 years ago

@mirkosoft I would suggest to create e2e test for those cases (button text with or without existing addresses)

Agree, I'll create ticket for that.