feat: add iframe parameter to security settings

lechnerc77 commented 2 months ago

Purpose

The parameter iframe_domains was added to the resources and data sources for security settings to be in sync with the BTP CLI
The resources for security settings can now be imported
According updates of the documentation and test cases
closes #904

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[X] Feature
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

Test the code via automated test

go test ./...

What to Check

Verify that the following are valid:

Automated tests are executed successfully

Other Information

Due to the make fmt some files have been formated that are not subject to the change

Checklist for reviewer

The following organizational tasks must be completed before merging this PR:

[X] The PR is assigned to the Terraform project and a status is set (typically "in review").
[X] The PR has the matching labels assigned to it.
[X] The PR has a milestone assigned to it.
[X] If the PR closes an issue, the issue is referenced.
[X] Possible follow-up items are created and linked.

lechnerc77 commented 2 months ago

Drift detection error is okay, as the test fixtures for the resources and data sources had to be re-recorded

diya-dhan commented 2 months ago

In the files examples/resources/btp_globalaccount_security_settings/resource.tf and examples/resources/btp_subaccount_security_settings/resource.tf, the attribute iframe_domains is a shown as a list although the attribute is a string as per the schema.

diya-dhan commented 2 months ago

In the file internal/provider/datasource_globalaccount_security_settings.go and internal/provider/datasource_globalaccount_security_settings_test.go, the attribute iframe_domains is configured as Optional as well as Computed. This is being reflected in the documentation as well.

lechnerc77 commented 1 month ago

In the files examples/resources/btp_globalaccount_security_settings/resource.tf and examples/resources/btp_subaccount_security_settings/resource.tf, the attribute iframe_domains is a shown as a list although the attribute is a string as per the schema.

Resolved

lechnerc77 commented 1 month ago

In the file internal/provider/datasource_globalaccount_security_settings.go and internal/provider/datasource_globalaccount_security_settings_test.go, the attribute iframe_domains is configured as Optional as well as Computed. This is being reflected in the documentation as well.

Fixed

diya-dhan commented 1 month ago

Drift detection can be ignored as fixtures were re-recorded

diya-dhan commented 1 month ago

Tested out changes, everything works fine

SAP / terraform-provider-btp