search

SAP / theming-base-content

Color, font and metric definitions of SAP themes to be used by application UIs and UI frameworks.
https://sap.github.io/theming-base-content/docs
Apache License 2.0
51 stars 15 forks source link

fix: delete unnecessary font-face declaration in belize plus #7

Closed Vita-Meow closed 2 years ago

Vita-Meow commented 2 years ago

fix #8

I guess these code should be here right? Because it should be a common part, and other themes like Belize and Fiori 3 or HCB HCW are all not having this. Beside I saw these already be written in all theme's preview.css

dominikschreiber commented 2 years ago

Thank you for contributing to the theming-base-content. You're right with your observation that the @font-face definitions should not be part of the css_variables.css files.

However, simply removing them from the css_variables.css file does not scale. The css_variables.css files are generated from the css_variables.less files in the upstream SAP-internal theming-base-content. With the next update of the open source theming-base-content (this repo) your changes would be overwritten again.

What you discovered seems to be a bug in the build of the theming-base-content. I'll debug into it and solve it upstream.

Vita-Meow commented 2 years ago

Thank you for contributing to the theming-base-content. You're right with your observation that the @font-face definitions should not be part of the css_variables.css files.

However, simply removing them from the css_variables.css file does not scale. The css_variables.css files are generated from the css_variables.less files in the upstream SAP-internal theming-base-content. With the next update of the open source theming-base-content (this repo) your changes would be overwritten again.

What you discovered seems to be a bug in the build of the theming-base-content. I'll debug into it and solve it upstream.

Also thanks for your explanation for details! Looking forward it!