search

SAP / ui5-inspector

With the UI5 Inspector, you can easily debug and support your OpenUI5/SAPUI5 based apps.
https://sap.github.io/ui5-inspector/
Apache License 2.0
144 stars 57 forks source link

fix: prevent duplicate output #235

Closed kineticjs closed 1 year ago

kineticjs commented 1 year ago

Fixes duplicate action execution the following scenario:

  1. Select a control from the control tree and execute an action e.g. 'copy control to console'
  2. Close and reopen the DevTools, while staying on the same page and URL (no navigation)
  3. Repeat step 1 Expected: the same result as received for step 1 Actual: the result is displayed twice (e.g. control is copied to the console twice)

On inspection we see that the content script "content/main.js" is injected each time the devTools is reopened. This happens on request from the script behind the UI5-Inspector tab in DevTools because that script is also re-executed whenever the DevTools panel is opened and it does not keep any state that persists between the multiple close and reopen of the panel.

Fixed by adding a flag to the window object that keeps the 'injected' state, so that the initializations inside the content script are not executed more than once.

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 1.6.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: