Vertical Layout Error at nested Grid

[AndreasTeufVoest]

`

` Here the xml shows for instance an error – because the Grid Tag must not be there concerning UI5 API however it is executable.. **this must not be in my point of view.** This has rather to be a warning in my PoV. Regards Andreas

[MN-public]

Hi Andreas, thanks for reporting the issue. We need to see your complete project or at least know the minUI5 version set in your project because the significant part of the validation is specific to the UI5-version.

[AndreasTeufVoest]

Hello Mariana,

I must not share projects with company code in it. But I can tell you that we’re still working on old versions, since we have not switched to S4 yet.

In the current case we use version 1.71.57

Regards

Andreas

Von: Mariana Naboka @.> Gesendet: Mittwoch, 15. November 2023 17:08 An: SAP/ui5-language-assistant @.> Cc: Teufer Andreas @.>; Author @.> Betreff: EXT: Re: [SAP/ui5-language-assistant] Vertical Layout Error at nested Grid (Issue #672)

EXTERNAL SENDER This email originated from outside of voestalpine. Do not click links or open attachments unless you recognize the sender and know the content is safe.

Hi Andreas, thanks for reporting the issue. We need to see your complete project or at least know the minUI5 version set in your project because the significant part of the validation is specific to the UI5-version.

— Reply to this email directly, view it on GitHubhttps://github.com/SAP/ui5-language-assistant/issues/672#issuecomment-1812820284, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BD7J5BXRDEJ2O3UJGYEVLJLYETSELAVCNFSM6AAAAAA7MGA7I2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJSHAZDAMRYGQ. You are receiving this because you authored the thread.Message ID: @.***>

[MN-public]

We could not reproduce your issue without the project. We understand, that you cannot share the business project in the open source github. Maybe you could create a dummy project showing the issue and share it with us? Or open the SNOW ticket to share your project securely with SAP? BTW: What is the error text you see?

[AndreasTeufVoest]

Hello,

we could schedule an Remote Session and I show you..

Regards

Andreas

Von: Mariana Naboka @.> Gesendet: Freitag, 17. November 2023 10:50 An: SAP/ui5-language-assistant @.> Cc: Teufer Andreas @.>; Author @.> Betreff: EXT: Re: [SAP/ui5-language-assistant] Vertical Layout Error at nested Grid (Issue #672)

EXTERNAL SENDER This email originated from outside of voestalpine. Do not click links or open attachments unless you recognize the sender and know the content is safe.

We could not reproduce your issue without the project. We understand, that you cannot share the business project in the open source github. Maybe you could create a dummy project showing the issue and share it with us? Or open the SNOW ticket to share your project securely with SAP? BTW: What is the error text you see?

— Reply to this email directly, view it on GitHubhttps://github.com/SAP/ui5-language-assistant/issues/672#issuecomment-1816054773, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BD7J5BULMHLIDLCPJOABZR3YE4XMRAVCNFSM6AAAAAA7MGA7I2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJWGA2TINZXGM. You are receiving this because you authored the thread.Message ID: @.**@.>>

[marufrasully]

@AndreasTeufVoest

can you please share which version of UI5 Language Assistance you are using and what is the diagnostic message you get?

I would be happy for a Remote Session. Please suggest time and communication channel.

[AndreasTeufVoest]

Hello,

@AndreasTeufVoesthttps://github.com/AndreasTeufVoest

can you please share which version of UI5 Language Assistance you are using and what is the diagnostic message you get?

I would be happy for a Remote Session. Please suggest time and communication channel.

-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~- -- Do not delete or change any of the following text. --

When it's time, join your Webex meeting here.

Join meetinghttps://voestalpine.webex.com/voestalpine/j.php?MTID=m0947191366dc32e93c3873dff5e96a1e

More ways to join:

Join from the meeting link https://voestalpine.webex.com/voestalpine/j.php?MTID=m0947191366dc32e93c3873dff5e96a1e

Join by meeting number Meeting number (access code): 2741 408 0380 Meeting password: tPPQC8CP3P7

Tap to join from a mobile device (attendees only) +43-720-815221,,27414080380##<tel:%2B43-720-815221,,0127414080380%23%2301> Austria toll +49-6196-7819736,,27414080380##<tel:%2B49-6196-7819736,,0127414080380%23%2301> Germany toll

Join by phone +43-720-815221 Austria toll +49-6196-7819736 Germany toll Global call-in numbershttps://voestalpine.webex.com/voestalpine/globalcallin.php?MTID=m5fa6cd5666188c5806279eb6574d0a2c

Join from a video system or application Dial @.**@.> You can also dial 62.109.219.4 and enter your meeting number.

If you are a host, click herehttps://voestalpine.webex.com/webappng/sites/voestalpine/meeting/info/5ae693a81911438687fc3e88022121b9 and login site to view host information.

Need help? Go to https://help.webex.com

[AndreasTeufVoest]

Seems this invitation didn't work out .. ;) ... where to send the invitation to?

[marufrasully]

@AndreasTeufVoest I just tried. Does it have session time out. you can send it here I try to rejoin or suggest a date with time.

[AndreasTeufVoest]

Hi,

sent you the appointment for tomorrow again.

Regards

Andreas

Von: mr25mr @.> Gesendet: Montag, 20. November 2023 14:24 An: SAP/ui5-language-assistant @.> Cc: Teufer Andreas @.>; Mention @.> Betreff: EXT: Re: [SAP/ui5-language-assistant] Vertical Layout Error at nested Grid (Issue #672)

EXTERNAL SENDER This email originated from outside of voestalpine. Do not click links or open attachments unless you recognize the sender and know the content is safe.

@AndreasTeufVoesthttps://github.com/AndreasTeufVoest I just tried. Does it have session time out. you can send it here I try to rejoin or suggest a date with time.

— Reply to this email directly, view it on GitHubhttps://github.com/SAP/ui5-language-assistant/issues/672#issuecomment-1819058071, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BD7J5BXCYQTNNLRANUFNZNTYFNKWPAVCNFSM6AAAAAA7MGA7I2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJZGA2TQMBXGE. You are receiving this because you were mentioned.Message ID: @.***>

[AndreasTeufVoest]

<mvc:View controllerName="com.voestalpine.vakf.zfwmvakffastpick.controller.FastKommi" xmlns:mvc="sap.ui.core.mvc" displayBlock="true" xmlns="sap.m" xmlns:l="sap.ui.layout" xmlns:s="sap.m.semantic" xmlns:f="sap.ui.layout.form">

</mvc:View>

[marufrasully]

@AndreasTeufVoest As per documentation the only allowed aggregation is 0..n of sap.m.Button so any another control should result in error. Therefore, error message is correct. If the app is working with UI5 version 1.71.57, it may not work in other UI5 versions. Please adapt your file content. Will below xml snippet be an option for you?

<s:customFooterContent>
    <Button
        id="btnpostMovement"
        tooltip="Accept"
        type="Accept"
        press="checkQuantity"
        icon="sap-icon://save"
        class="sapUiTinyMarginTopBottom"
    />
    <Button
        id="btnabort"
        tooltip="Abort"
        type="Reject"
        press="onAbort"
        icon="sap-icon://decline"
        class="sapUiTinyMarginTopBottom"
    />
</s:customFooterContent>

width="100%" is removed. With above content, two buttons are rendered at right bottom corner as per SAP Fiori 1.0 design guidelines.

If above is not an acceptable option, please change from sap.m.semantic.DetailPage to sap.m.Page instead. Sample code snippet

    <App id="app">
        <pages>
            <Page>
                <content>
                    
                </content>
                <footer>
                    <Bar>
                        <Button
                            id="btnpostMovement"
                            tooltip="Accept"
                            type="Accept"
                            press="checkQuantity"
                            icon="sap-icon://save"
                            class="sapUiTinyMarginTopBottom"
                        />
                        <Button
                            id="btnabort"
                            tooltip="Abort"
                            type="Reject"
                            press="onAbort"
                            icon="sap-icon://decline"
                            class="sapUiTinyMarginTopBottom"
                        />
                    </Bar>
                </footer>
            </Page>
        </pages>
    </App>

The UI looks like

I hope this solves your issue. If not please open a ticket on UI5 component and close this issue.

Thanks and regards MR

[MN-public]

@AndreasTeufVoest I think the bottom line here is that using of such structure is not supposed to work in runtime, the fact that it works now is a pure coincidence and can be changed at any time without any notice in a new UI5 version or even in the one you are using now (via some fix). So the error message is supposed to inform you that it should not be used in that context to prevent any issues with your app (current or future). To me this is a valid reason to keep it as an error. Please consider other options to use the desired app behaviour as outlined above in https://github.com/SAP/ui5-language-assistant/issues/672#issuecomment-1825669889 I'm closing this ticket as answered