fix: relax diagnostics for aggregation which have alternative types

SAP / ui5-language-assistant

VSCode Extension and Editor Tooling for SAPUI5

Apache License 2.0

54 stars 25 forks source link

fix: relax diagnostics for aggregation which have alternative types #682

Closed marufrasully closed 8 months ago

marufrasully commented 9 months ago

Issue: https://github.com/SAP/ui5-language-assistant/issues/678

This PR includes

Enhance hover documentation with Alternative types: <type> for aggregation which have altTypes
Include Property Binding Info properties also for aggregation which have altTypes of PrimitiveType kind
No unjustified diagnostics for aggregation which have altTypes of PrimitiveType kind
Unit tests to cover above cases

changeset-bot[bot] commented 9 months ago

🦋 Changeset detected

Latest commit: 0ec31fe8d88375d47b7c10995c858c239b031a23

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages

| Name | Type | | ------------------------------------------------------------- | ----- | | @ui5-language-assistant/vscode-ui5-language-assistant-bas-ext | Patch | | vscode-ui5-language-assistant | Patch | | @ui5-language-assistant/language-server | Patch | | @ui5-language-assistant/binding | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

sonarcloud[bot] commented 8 months ago

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
96.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud