search

SAP / ui5-language-assistant

VSCode Extension and Editor Tooling for SAPUI5
Apache License 2.0
53 stars 25 forks source link

Feat: add goto controller's definition from xml view files #701

Closed marufrasully closed 3 months ago

marufrasully commented 3 months ago

Issue: #702

This PR creates a new module "@ui5-language-assistant/xml-views-definition" and implement go to controller's definition (.js or .ts) from xml view files. It support following format.

The only considered xml attributes are

File resolution logic is as follows:

  1. it tries to load <path>.controller.js
  2. it tries to load <path>.js
  3. it tries to load <path>.controller.ts
  4. it tries to load <path>.ts
changeset-bot[bot] commented 3 months ago

🦋 Changeset detected

Latest commit: 0262f3a19db147ae8f8434225ca084f5ea4b060d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages | Name | Type | | ------------------------------------------------------------- | ----- | | @ui5-language-assistant/vscode-ui5-language-assistant-bas-ext | Patch | | vscode-ui5-language-assistant | Patch | | @ui5-language-assistant/xml-views-completion | Patch | | @ui5-language-assistant/xml-views-definition | Patch | | @ui5-language-assistant/xml-views-validation | Patch | | @ui5-language-assistant/xml-views-tooltip | Patch | | @ui5-language-assistant/language-server | Patch | | @ui5-language-assistant/context | Patch | | @ui5-language-assistant/binding | Patch | | @ui5-language-assistant/fe | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
97.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud