search

SAP / ui5-linter

A static code analysis tool for UI5
Apache License 2.0
47 stars 4 forks source link

refactor: Refactoring of detect Component best practices PR #127

Closed RandomByte closed 4 months ago

RandomByte commented 4 months ago

Test case Positive_11 seems to not detect the missing async flags/interface. Need to look into this tomorrow

d3xter666 commented 4 months ago

Test case Positive_11 seems to not detect the missing async flags/interface. Need to look into this tomorrow

The issue is that the Component does not have members (https://github.com/SAP/ui5-linter/pull/127/files#diff-b33fcef6fb0b205372cd4799b7486a23abf3f17b4461bc35e21a0466ad1e9179R89), therefore the check for the manifest.json gets skipped. The manifest is not propagetd to the parent component analysis and it never got checked: https://github.com/SAP/ui5-linter/pull/127/files#diff-b33fcef6fb0b205372cd4799b7486a23abf3f17b4461bc35e21a0466ad1e9179R106 It should have been working before as a side effect of the propagation to the parent component.

RandomByte commented 4 months ago

Test case Positive_11 seems to not detect the missing async flags/interface. Need to look into this tomorrow

The issue is that the Component does not have members (https://github.com/SAP/ui5-linter/pull/127/files#diff-b33fcef6fb0b205372cd4799b7486a23abf3f17b4461bc35e21a0466ad1e9179R89), therefore the check for the manifest.json gets skipped. The manifest is not propagetd to the parent component analysis and it never got checked: https://github.com/SAP/ui5-linter/pull/127/files#diff-b33fcef6fb0b205372cd4799b7486a23abf3f17b4461bc35e21a0466ad1e9179R106 It should have been working before as a side effect of the propagation to the parent component.

Great, thanks! Changed the fixture, and even fixed a bug Unhandled CallExpression expression syntax: SuperKeyword