search

SAP / ui5-manifest

This project contains the flattend json schema for the ui5 manifest.
Apache License 2.0
30 stars 9 forks source link

Application Schema and CIL Schema separate flattened (V25) #10

Closed aleksandr-suvorov closed 4 years ago

aleksandr-suvorov commented 4 years ago

AppSescriptor Schema V25 (1.24.0):

  1. two separate schemas
  2. removed extra http://adaptivecards.io reference
silkearians commented 4 years ago

Thanks a lot Alex. Please also mention that this is new V25 ... Was there also a change in naming the definitions: "$ref": "#/properties/sap.app/definitions/id_def" to "$ref": "#/definitions/id_def" ?

bd82 commented 4 years ago

I do not have an opinion on the split up of the schemas. As long as the reference: https://raw.githubusercontent.com/SAP/ui5-manifest/master/schema.json remains valid for the common scenario.

aleksandr-suvorov commented 4 years ago

@silkearians I moved both (app & cil) references out of "anyOf" array, and the links changed accordingly

silkearians commented 4 years ago

@silkearians I moved both (app & cil) references out of "anyOf" array, and the links changed accordingly

Thanks Alex, I am only confused as the diff for schema.json shows many differences, or is it only a display issue?

aleksandr-suvorov commented 4 years ago

@silkearians definition which were previously located in subschemas, like sap.app, sap.ui5 and so on, are now located in the root of schema.

silkearians commented 4 years ago

Please also mention that this is new V25 ...