Possible incorrect pattern property for "sap.ui5.dependencies.libs"

SAP / ui5-manifest

This project contains the flattend json schema for the ui5 manifest.

Apache License 2.0

30 stars 9 forks source link

Possible incorrect pattern property for "sap.ui5.dependencies.libs" #24

Open tsteckenborn opened 6 months ago

tsteckenborn commented 6 months ago

Hi there,

It could be that the pattern defined is incorrect:

https://github.com/SAP/ui5-manifest/blob/fce1a7ee50c3f6560e6e97e7e3771df5c982107f/schema.json#L608-L617

It seems to support further characters, such as - and _.

So potentially the pattern should be adapted.

Best regards, Tobias

aleksandr-suvorov commented 6 months ago

Hi Tobias,

according to our tests and requirements, this regex pattern doesn't allow - and _ characters in library names. Do you have a specific library or scenario?

Best regards, Aleksandr