SAP / ui5-tooling

An open and modular toolchain to develop state of the art applications based on the UI5 framework
https://sap.github.io/ui5-tooling
Apache License 2.0
465 stars 69 forks source link

Tooling builds library to resources subfolder, while app doesn't. #156

Closed uxkjaer closed 5 years ago

uxkjaer commented 5 years ago

We recently moved to the new tooling for our apps and libraries in our CI. With the libraries it did break some stuff as they are added to dist/resources folder. This means that when we run our deploy task it deploys straight from the dist/ and the path then becomes obscured and the Gateway server can't figure it out. Is that a bug in the tooling or should we make our CI behave?

Expected Behavior

UI5 build would add library straight to the dist folder

Current Behavior

ui5 build adds library to /dist/resources

Steps to reproduce the issue

  1. Create a library
  2. Run UI5 Build
  3. See dist folder

Context

Affected components (if known)

Log Output / Stack Trace

{...}
RandomByte commented 5 years ago

The content of the dist directory is supposed to reflect the directory structure as expected at UI5 runtime. By default, libraries are loaded from /resources/<library namespace>.

This is also documented here: https://github.com/SAP/ui5-builder#library ("virtual directories" become physical directories in dist)

This allows to build an app with all its dependencies and then just start any http server on the dist directory.

Can you possibly adapt your deploy script to transform the structure to what is expected on your server platform?

uxkjaer commented 5 years ago

All good. We have done that already. Just wanted to highlight it