search

SAP / ui5-tooling

An open and modular toolchain to develop state of the art applications based on the UI5 framework
https://sap.github.io/ui5-tooling
Apache License 2.0
466 stars 71 forks source link

Recheck encoding of i18n files #161

Closed lukasriederle closed 5 years ago

lukasriederle commented 5 years ago

Expected Behavior

i18n files should be readable in UTF8 at least as option

Current Behavior

utf8 files get read with wrong character set what leads to issues with e.g. German umlauts Especially this is an issue in combination with SAP Translation Hub witch is translating into UTF8 using a manual conversion is not an option for bigger projects with many languages. https://github.com/SAP/ui5-builder/issues/105

Steps to reproduce the issue

see https://github.com/SAP/ui5-builder/issues/105

Context

see https://github.com/SAP/ui5-builder/issues/105

Affected components (if known)

Log Output / Stack Trace

see https://github.com/SAP/ui5-builder/issues/105

htammen commented 5 years ago

I opened a similar issue in ui5-server. This was fixed with ui5-cli version 1.5.3. Probably this is helpful for you, too. https://github.com/SAP/ui5-server/issues/196

matz3 commented 5 years ago

We are currently working on a concept to better handle encoding of properties files: https://github.com/SAP/ui5-tooling/pull/168

RandomByte commented 5 years ago

With UI5 CLI v1.7.0, you can now configure UTF-8 as the source encoding of a projects *.properties files. The default stays at ISO-8859-1. In both cases the UI5 Tooling will escape any non-ASCII characters, so that the build result is independent from the encoding.

📖 Documentation (see propertiesFileSourceEncoding)
🔎 Demo