SAP / ui5-tooling

An open and modular toolchain to develop state of the art applications based on the UI5 framework
https://sap.github.io/ui5-tooling
Apache License 2.0
470 stars 71 forks source link

SAPUI5 1.71 is not supported #265

Open DenisTis opened 4 years ago

DenisTis commented 4 years ago

Dear team, this setup is not supported by the tool:

specVersion: "2.2"
type: application
metadata:
  name: CompanyRepo.appName
framework:
  name: SAPUI5
  version: 1.71.26

Could you please enable it for all SAPUI5 versions, which are on maintenance mode: (https://sapui5.hana.ondemand.com/versionoverview.html )

DenisTis commented 4 years ago

I tried it also with version 1.71.0 - same result

RandomByte commented 4 years ago

Hi @DenisTis,

The minimum SAPUI5 version that can be installed by the UI5 Tooling is 1.76.0.

The command ui5 use sapui5@1.71.26 will also output the following error message:

Could not resolve framework version 1.71.26. Note that SAPUI5 framework libraries can only be consumed by the UI5 Tooling starting with SAPUI5 v1.76.0

However, there are workarounds for simple local development use cases. We plan on writing a blog post or similar illustrating those.

In your projects index.html you could for example use the CDN URL https://sapui5.hana.ondemand.com/resources/sap-ui-core.js for bootstrapping UI5. You can also use the “simpleproxy” middleware from https://github.com/ui5-community/ui5-ecosystem-showcase to proxy a CDN hosted 1.71 version for local use. To work fully offline, you can also download a runtime archive from https://tools.hana.ondemand.com/#sapui5 and serve it using the “servestatic” middleware, also from the ui5-ecosystem-showcase project.

You can find a related discussion in the OpenUI5 Slack: https://openui5.slack.com/archives/C0A7MHSSJ/p1597649506340800 (invite)

treee111 commented 2 years ago

Hi @RandomByte, should this work for proxying a e.g. UI5 1.71.35 version for usage with ui5tooling? For me this does not work...

server:
  customMiddleware:
  - name: ui5-middleware-simpleproxy
    afterMiddleware: compression
    mountPath: /resources
    configuration:
      baseUri: "https://sapui5.hana.ondemand.com/1.71.35/resources/sap-ui-core.js"
      strictSSL: false

Thanks!

matz3 commented 2 years ago

@treee111 I think the baseUri needs to end with /resources (without the /sap-ui-core.js).

treee111 commented 2 years ago

Hi @matz3, thanks for pointing this out! Your absolutely right, this works! I tried it with the https://github.com/SAP/openui5-sample-app. However it doesn't work with our custom apps out of the box. I'll check if I find the problem and if not, open a separate issue with a example app & library.

thanks! 👍

RandomByte commented 2 years ago

Glad to hear that. Please take care to open issues for ui5-middleware-simpleproxy in the community repository: https://github.com/ui5-community/ui5-ecosystem-showcase

treee111 commented 2 years ago

Thanks @RandomByte and @matz3, I opened a rather long issue in the community repository with a explenation of what I want to achieve (also linked it to this issue).

If you have some time, maybe you could also have a look and clarify things as I think you have a good understanding of the UI5Tooling possibilities in general.

piejanssens commented 2 years ago

Proxy works, but is way slower. @RandomByte @matz3 Please consider supporting 1.71 which is supported by SAP until Q4 2027!