Open sebbi08 opened 3 years ago
One more comment if i comment out the Validation error in node_modules/@ui5/cli/node_modules/@ui5/project/lib/validation/validator.js
everything is working as expected
The when a shim is applied, the project configuration (if existing) is enhanced (i.e. merged).
I think we haven't fully thought about such cases, as most use-case are about shims for non-UI5 projects. When the project type is changed it might result into an invalid configuration. In this case the "framework" property is not applicable for type module.
IMO the validation should still take place (at least for the shim config parts), but maybe we need to detect such cases (different type) and do a cleanup to remove not applicable configuration.
Regardless of the actual solution, I also see this as a bug that should be addressed.
The issue when using type application is that we don't allow more than one application in the tree. But I'd have expected such a message in the log, so I think we should also follow-up on this one to at least provide a better error message.
Hi, we set up a project (Project1) with the ui5 cli version 1 and defind a second project (Project2) of type "application" as dependency because we have some code in the second app we would like to reuse in the second app.
By the time in v1 the cli was not able to put that app dependency inside the served folder's
Because of that we create a shim that looks like this
But with v2 of the tooling this is not working anymore because it throws an error on serve:
I also tried to change the type of the shim to type "application" but this gives me another error
May it be possible to disable the YAML validation for the shims?
Expected Behavior
I can run serve and get my defined shim loaded
Current Behavior
See above
Steps to Reproduce the Issue
See above
Context
ui5 --version
when using the CLI):2.12.0
v14.16.1
6.14.12
MAC OSX
unknown
nothing
Log Output / Stack Trace
With type module
With type application