search

SAP / ui5-tooling

An open and modular toolchain to develop state of the art applications based on the UI5 framework
https://sap.github.io/ui5-tooling
Apache License 2.0
466 stars 69 forks source link

Add --browser cli argument for changing the default browser #712

Open zdravko-georgiev opened 1 year ago

zdravko-georgiev commented 1 year ago

Is your feature request related to a problem? Please describe.

Using ui5 serve --open will open the server root directory in the default browser. But if you want to use a browser different than the default system browser, there is no way to specify it.

Describe the solution you'd like

The open package used by the ui5-tooling supports this feature. A simple solution could be adding an additional cli argument, e.g. --browser when one can specify the browser to be used, e.g. chrome|firefox|edge, the value can be then used when executing the open request.

Describe alternatives you've considered

Copying link and manually opening it in the desired browser

Additional context

Asked also by the community: https://answers.sap.com/questions/13751060/change-default-browser-used-by-vscodefiori-tools.html

RandomByte commented 1 year ago

Sounds like a good suggestion. The API is documented here: https://github.com/sindresorhus/open#usage

Maybe we should look into this together with: https://github.com/SAP/ui5-tooling/issues/623